fix panic in ingester when not running with boltdb shipper while queriers does #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
+ Coverage 61.30% 61.33% +0.03%
==========================================
Files 179 179
Lines 14438 14438
==========================================
+ Hits 8851 8856 +5
+ Misses 4780 4773 -7
- Partials 807 809 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When ingesters are not running
boltdb-shipper,GetChunkIDsproto call returns anilresponse instead of empty response which causes ingesters to panic, trying to marshal a nil value. This would happen when ingesters are not runningboltdb-shipperwhile queriers are.