-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates docs with delete permissions notice #2819
Conversation
@oddlittlebird, looking at this now. |
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
=======================================
Coverage 61.30% 61.30%
=======================================
Files 179 179
Lines 14438 14438
=======================================
Hits 8851 8851
- Misses 4775 4779 +4
+ Partials 812 808 -4
|
ad92e27
to
ce2f562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor copy-edit suggestions.
@@ -113,6 +113,10 @@ We recommend running a Compactor since a single Ingester creates 96 files per da | |||
|
|||
Example compactor configuration with GCS: | |||
|
|||
#### Delete Permissions | |||
|
|||
In the course of compacting index files, the compactor writes a new file and deletes the unoptimized ones. Therefore, ensure the compactor has appropriate permissions for deleting files, such as `s3:DeleteObject` for AWS S3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When compacting index files, the compactor writes a new file and deletes all unoptimized files. Ensure that the compactor has appropriate permissions for deleting files, for example, s3:DeleteObject
permission for AWS S3.
docs/sources/upgrading/_index.md
Outdated
@@ -154,6 +154,10 @@ Ingesters now expose a new RPC method that queriers use when the index type is ` | |||
Queriers generally roll out faster than ingesters, so if new queriers query older ingesters using the new RPC, the queries would fail. | |||
To avoid any query downtime during the upgrade, rollout ingesters before queriers. | |||
|
|||
#### If running the compactor, ensure it has delete permissions for the object storage. | |||
|
|||
The compactor is an optional but suggested component combines and deduplicates the boltdb-shipper index files. In the course of compacting these, it writes a new file and deletes the unoptimized ones. Therefore, ensure the compactor has appropriate permissions for deleting files in this bucket, such as `s3:DeleteObject` for AWS S3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compactor is an optional but suggested component that combines and deduplicates the boltdb-shipper index files. When compacting index files, the compactor writes a new file and deletes all unoptimized files. Ensure that the compactor has appropriate permissions for deleting files, for example, s3:DeleteObject permission for AWS S3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.