Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: Log throughput and total bytes human readable. #2751

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Logging: Log throughput and total bytes human readable. #2751

merged 1 commit into from
Nov 4, 2020

Conversation

jeschkies
Copy link
Contributor

What this PR does / why we need it:
With LogQL 2.0 we will be able to parse byte sizes such as KiB.

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jeschkies jeschkies mentioned this pull request Oct 12, 2020
Closed
2 tasks
@cyriltovena
Copy link
Contributor

This looks good, just putting on hold until we can extract metrics from it.

cyriltovena
cyriltovena approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 55c768b into grafana:master Nov 4, 2020
@jeschkies jeschkies deleted the karsten/log-mb branch December 14, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeschkies @CLAassistant @cyriltovena