Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: clean getStore #2726

Merged
merged 1 commit into from
Oct 7, 2020
Merged

hack: clean getStore #2726

merged 1 commit into from
Oct 7, 2020

Conversation

dvrkps
Copy link
Contributor

@dvrkps dvrkps commented Oct 5, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #2726 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
+ Coverage   61.44%   61.47%   +0.02%     
==========================================
  Files         173      173              
  Lines       13465    13465              
==========================================
+ Hits         8274     8277       +3     
+ Misses       4435     4433       -2     
+ Partials      756      755       -1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+2.11%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@owen-d owen-d merged commit 69f2eb2 into grafana:master Oct 7, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants