Promtail: Fix timestamp parser for short year format #2708

Falco20019 · 2020-10-01T14:34:48Z

What this PR does / why we need it:
Using a short year format for timestamp in the pipeline break if trying to parse older log files.

...
scrape_configs:
- pipeline_stages:
...
  - timestamp:
      source: time
      format: 02.01.06 03:04:05.000
...

Which issue(s) this PR fixes:
Fixes #2653

Special notes for your reviewer:
I don't have a golang environment on my machine and was not able to properly run the Makefile on windows either. Only traced the cause by looking into the code base. I hope there is CI testing it.

Checklist

Documentation added
-- Not necessary as it's a bug fix
Tests updated

CLAassistant · 2020-10-01T14:34:53Z

All committers have signed the CLA.

cyriltovena

LGTM

Signed-off-by: Cyril Tovena <[email protected]>

Fix timestamp parser for short year format

18fe186

pull-request-size bot added the size/S label Oct 1, 2020

cyriltovena approved these changes Oct 1, 2020

View reviewed changes

cyriltovena merged commit 9e6afea into grafana:master Oct 1, 2020

Falco20019 deleted the patch-1 branch October 9, 2020 06:24

cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020

Fix timestamp parser for short year format (grafana#2708)

f6eb8d6

Signed-off-by: Cyril Tovena <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promtail: Fix timestamp parser for short year format #2708

Promtail: Fix timestamp parser for short year format #2708

Falco20019 commented Oct 1, 2020

CLAassistant commented Oct 1, 2020 •

edited

Loading

cyriltovena left a comment

Promtail: Fix timestamp parser for short year format #2708

Promtail: Fix timestamp parser for short year format #2708

Conversation

Falco20019 commented Oct 1, 2020

CLAassistant commented Oct 1, 2020 • edited Loading

cyriltovena left a comment

Choose a reason for hiding this comment

CLAassistant commented Oct 1, 2020 •

edited

Loading