Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/querier: fix dropped error #2671

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 25, 2020

This fixes a dropped error in pkg/querier.

Signed-off-by: Lars Lehtonen <[email protected]>
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@codecov-commenter
Copy link

Codecov Report

Merging #2671 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
- Coverage   61.46%   61.39%   -0.08%     
==========================================
  Files         173      173              
  Lines       13410    13412       +2     
==========================================
- Hits         8243     8234       -9     
- Misses       4419     4425       +6     
- Partials      748      753       +5     
Impacted Files Coverage Δ
pkg/querier/querier.go 70.12% <0.00%> (-0.59%) ⬇️
pkg/promtail/targets/file/tailer.go 68.53% <0.00%> (-8.99%) ⬇️
pkg/promtail/targets/file/filetarget.go 64.08% <0.00%> (-2.12%) ⬇️
pkg/ingester/transfer.go 60.46% <0.00%> (+1.55%) ⬆️

@sandeepsukhani sandeepsukhani merged commit 0c9f7a5 into grafana:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants