Tests: fix issue 2356: distributor_test.go fails when the system has no interface name in [eth0, en0, lo0] #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestDistributor_PushIngestionRateLimiter failed if the system had no interface name in "eth0", "en0" or "lo0". Fix that by looking at the name of the loopback interface in the list of the system's network interfaces, then using that name in the test. Fixes grafana#2356
|
|
Codecov Report
@@ Coverage Diff @@
## master #2645 +/- ##
==========================================
+ Coverage 61.16% 61.21% +0.04%
==========================================
Files 172 172
Lines 13358 13358
==========================================
+ Hits 8171 8177 +6
+ Misses 4437 4431 -6
Partials 750 750
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* improve query speed when does not enable caching Signed-off-by: storyicon <[email protected]> * Update pkg/chunk/cache/tiered.go Co-authored-by: Ganesh Vernekar <[email protected]> Signed-off-by: storyicon <[email protected]> * simplify optimization Signed-off-by: storyicon <[email protected]> Co-authored-by: Ganesh Vernekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
TestDistributor_PushIngestionRateLimiterfailed if the system had no interface name in "eth0", "en0" or "lo0".Fix that by looking at the name of the loopback interface in the list of the system's network interfaces, then using that name in the test.
Which issue(s) this PR fixes:
Fixes #2356
Special notes for your reviewer:
Checklist