fix a panic when trying to stop boltdb-shipper multiple times using sync.once #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 62.93% 62.87% -0.06%
==========================================
Files 169 169
Lines 15023 15025 +2
==========================================
- Hits 9454 9447 -7
- Misses 4812 4821 +9
Partials 757 757
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When boltdb-shipper is used in multiple schema configs we share the same instance. When we stop the store service it tries to stop the same boltdb-shipper client multiple times causing it to panic on already closed channel.
This PR fixes the issue by using sync.Once.
Which issue(s) this PR fixes:
Fixes #2609
Checklist