Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose UserAgent and fix User-Agent version source #2603

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Expose UserAgent and fix User-Agent version source #2603

merged 2 commits into from
Sep 8, 2020

Commits on Sep 8, 2020

  1. Use prometheus/common/version for reporting build version in User Age… 

    …nt header

Promtail wasn't using github.com/prometheus/common/version for the
User-Agent header when obtaining the build version. Instead, it imported
github.com/grafana/loki/pkg/build which modifies the Prometheus version
package on init.

This causes problems for importers that also import and modify
github.com/prometheus/common/version with their own build information
(i.e., grafana/agent).

This PR changes Promtail to obtain the build info from the common
dependency to obtain the correct build information regardless of
how Promtail is being run.
    @rfratto
    rfratto committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    b2414c8 View commit details
    Browse the repository at this point in the history

  2. expose UserAgent to allow it to be modifiable by importers

    @rfratto
    rfratto committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    857f1f5 View commit details
    Browse the repository at this point in the history