Update README.md #2594
Merged
Update README.md #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated to required Go version
slim-bean
reviewed
Sep 3, 2020
README.md
Outdated
| @@ -99,7 +99,7 @@ Refer to [CONTRIBUTING.md](CONTRIBUTING.md) | |||
|
|
|||
| Loki can be run in a single host, no-dependencies mode using the following commands. | |||
|
|
|||
| You need `go` [v1.10+](https://golang.org/dl/) installed locally. | |||
| You need `go` [v1.14+](https://golang.org/dl/) installed locally. | |||
There was a problem hiding this comment.
I'm not sure that we strictly require 1.14? For that matter I don't know if we strictly require 1.10 or later.
I wonder if we should reword this to something like:
You need `go`, we recommend using the version found in [our build Dockerfile](https://github.com/grafana/loki/blob/master/loki-build-image/Dockerfile)
There was a problem hiding this comment.
I was not able to build Loki with Go version 1.13.x. Referring to the docker file version would keep these instructions evergreen.
There was a problem hiding this comment.
Good to know, not sure why this would be!?
slim-bean
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated required Go version for building loki
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist