Ignore .exe files build for Windows #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Loki on Windows with `go build ./cmd/loki` command, it creates file `/loki.exe`, but .gitignore has only `/loki`. Same with `promtail.exe`, `logcli.exe` and `loki-canary.exe`. Also it is safe to assume that no `.exe` files should be tracked by git in Loki.
|
|
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 63.46% 63.36% -0.10%
==========================================
Files 166 166
Lines 14582 14582
==========================================
- Hits 9254 9240 -14
- Misses 4586 4600 +14
Partials 742 742
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Loki on Windows with
go build ./cmd/lokicommand, it creates file/loki.exe, but .gitignore has only/loki.Same with
promtail.exe,logcli.exeandloki-canary.exe.Also it is safe to assume that no
.exefiles should be tracked by git in Loki.