Docker logging driver: Add a keymod for the extra attributes from the Docker logging driver #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2459 +/- ##
==========================================
- Coverage 62.90% 62.74% -0.16%
==========================================
Files 162 162
Lines 13964 13966 +2
==========================================
- Hits 8784 8763 -21
- Misses 4496 4519 +23
Partials 684 684
|
owen-d
reviewed
Aug 10, 2020
There was a problem hiding this comment.
Hey, thanks for the PR. I'm not very familiar with this part of the codebase but this looks sound. I'd really like to see some test additions to give confidence and help prevent regressions in the future.
Sorry for the wait and thanks for the well reasoned issue/pr :)
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
cyriltovena
approved these changes
Sep 17, 2020
stale
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Docker labelling best practices are to use labels with reverse DNS notation, but as Prometheus has a completely different view on this, it makes it very incompatible to collect custom labels which abide by Docker labelling practices, using the Docker logging driver.
Currently, the code has some special treatment for the Docker's labels, it should be possible to generalize this.
An easy way is to do a keymod when getting the extra attributes from Docker and replacing every
.by_Which issue(s) this PR fixes:
Fixes #2455
Special notes for your reviewer:
Checklist