loki-docker-driver: Change "ignoring empty line" to debug logging #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnathan Falk <[email protected]>
|
|
Codecov Report
@@ Coverage Diff @@
## master #2343 +/- ##
==========================================
- Coverage 61.50% 61.48% -0.03%
==========================================
Files 160 160
Lines 13422 13422
==========================================
- Hits 8255 8252 -3
- Misses 4546 4547 +1
- Partials 621 623 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johnathan Falk [email protected]
What this PR does / why we need it:
This PR changes the error message "ignoring empty line" to be a debug not info message so it doesn't clutter and destroy logs.
Which issue(s) this PR fixes:
Fixes #2342
Special notes for your reviewer:
One misbehaving docker container can spam millions of messages in day by having this as default info. Yes you should fix the container, but this also shouldn't fill my log drive with useless messages.
Checklist