Loki: Transfer one chunk at a time per series during chunk transfers #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2328 +/- ##
==========================================
+ Coverage 61.16% 61.27% +0.11%
==========================================
Files 158 158
Lines 12799 12798 -1
==========================================
+ Hits 7828 7842 +14
+ Misses 4374 4362 -12
+ Partials 597 594 -3
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Remove AWS based autoscaler code We still support metrics based autoscaling. Fixes cortexproject/cortex#1379 Signed-off-by: Goutham Veeramachaneni <[email protected]> * Remove unused function. Signed-off-by: Tom Wilkie <[email protected]> * Remove unused vendor code. Signed-off-by: Tom Wilkie <[email protected]> * Fix bad rebase. Signed-off-by: Tom Wilkie <[email protected]> Co-authored-by: Tom Wilkie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With very large volume log streams and
chunk_retain_periodenabled it's possible for a stream to have many chunks in memory.The previous behavior would send all those chunks in one GRPC payload which can hit the GRPC limits for sending.
This PR introduces a change to send the chunks one at a time to better utilize the GRPC connection and prevent exceeding limits.