Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metric queries by computing samples at the edges. #2293

Merged
merged 37 commits into from
Jul 11, 2020
Merged

Improve metric queries by computing samples at the edges. #2293

merged 37 commits into from
Jul 11, 2020

Commits on Jun 23, 2020

  1. First pass breaking the code appart. 

    Wondering how we're going to achieve fast mutation of labels.

Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    76712e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Work in progress. 

    I realize I need hash for deduping lines.
going to benchmark somes.

Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    a023059 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Tested some hash and decided which one to use. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    04a3204 View commit details
    Browse the repository at this point in the history

  2. Wip 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    92aa76f View commit details
    Browse the repository at this point in the history

  3. Starting working on ingester. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4786b30 View commit details
    Browse the repository at this point in the history

  4. Trying to find a better hash function. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    1b5d1de View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2020

  1. More hash testing we have a winner. xxhash it is. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    a4d1ca7 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Settle on xxhash 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    0db0d2a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into logql-edge-sample 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    600baa7 View commit details
    Browse the repository at this point in the history

  3. Better params interfacing. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    265ea0f View commit details
    Browse the repository at this point in the history

  4. Add interface for queryparams for things that exist in both type of p… 

    …arams.

Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    e22e6d1 View commit details
    Browse the repository at this point in the history

  5. Add storage sample iterator implementations. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    683fbb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Fixing tests and verifying we don't get collions for the hashing method. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    aa43f9a View commit details
    Browse the repository at this point in the history

  2. Fixing ingesters tests and refactoring utility function/tests. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    57ab4f6 View commit details
    Browse the repository at this point in the history

  3. Fixing and testing that stats are still well computed. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    31d0e55 View commit details
    Browse the repository at this point in the history

  4. Fixing more tests. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    fa5e456 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. More engine tests finished. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    0507d6c View commit details
    Browse the repository at this point in the history

  2. Fixes sharding evaluator. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    b7cede9 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Fixes more engine tests. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    d58b056 View commit details
    Browse the repository at this point in the history

  2. Fix error tests in the engine. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    415f46c View commit details
    Browse the repository at this point in the history

  3. Finish fixing all tests. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    add9c8c View commit details
    Browse the repository at this point in the history

  4. Fixes a bug where extractor was not passed in correctly. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    18529a0 View commit details
    Browse the repository at this point in the history

  5. Add notes about upgrade. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    e1d3aa6 View commit details
    Browse the repository at this point in the history

  6. Renamed and fix a bug. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    421a3eb View commit details
    Browse the repository at this point in the history

  7. Add memchunk tests and starting test for sampleIterator. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    7999b20 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Test heap sample iterator. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    9c0b656 View commit details
    Browse the repository at this point in the history

  2. working on test. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    28575e9 View commit details
    Browse the repository at this point in the history

  3. Finishing testing all new iterators. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    7abfe3b View commit details
    Browse the repository at this point in the history

  4. Making sure all store functions are tested. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    a5895a8 View commit details
    Browse the repository at this point in the history

  5. Benchmark and verify everything is working well. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    ca442ab View commit details
    Browse the repository at this point in the history

  6. Make the linter happy. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    f3f326d View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into logql-edge-sample 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    4fa7ea7 View commit details
    Browse the repository at this point in the history

  8. use xxhash v2. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    6caf45f View commit details
    Browse the repository at this point in the history

  9. Fix a flaky test because of map. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    583de7e View commit details
    Browse the repository at this point in the history

  10. go.mod. 

    Signed-off-by: Cyril Tovena <[email protected]>
    @cyriltovena
    cyriltovena committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    99c21f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2020

  1. Merge branch 'master' into logql-edge-sample 

    # Conflicts:
#	pkg/ingester/instance.go
#	pkg/logql/series_extractor_test.go
    @slim-bean
    slim-bean committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    5eaa32b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into logql-edge-sample

    @slim-bean
    slim-bean committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    a01f903 View commit details
    Browse the repository at this point in the history