Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for memberlist dns-based discovery #2288

Merged
merged 3 commits into from
Jul 3, 2020

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Jul 3, 2020

What this PR does / why we need it:
This PR updates the vendored dependencies for cortex to 0ea5a8b5. This updates includes dns-based memberlist discovery as described here.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

/cc @slim-bean

@codecov-commenter
Copy link

Codecov Report

Merging #2288 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2288      +/-   ##
==========================================
+ Coverage   62.30%   62.35%   +0.04%     
==========================================
  Files         158      158              
  Lines       12761    12761              
==========================================
+ Hits         7951     7957       +6     
+ Misses       4196     4192       -4     
+ Partials      614      612       -2     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.54% <0.00%> (+0.40%) ⬆️
pkg/querier/queryrange/downstreamer.go 97.93% <0.00%> (+2.06%) ⬆️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+2.27%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks !

@cyriltovena cyriltovena merged commit bc4f1f5 into grafana:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants