Fix ingester results for series query #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
+ Coverage 62.44% 62.47% +0.03%
==========================================
Files 158 158
Lines 12762 12769 +7
==========================================
+ Hits 7969 7978 +9
Misses 4177 4177
+ Partials 616 614 -2
|
|
The other PR I have open is gonna screw this one up a bit, and also looks like I introduce another case where you could hit this same bug, I'd like to get that merged first if we could. Also we should see if we can get some tests on this, that would be good. |
|
FYI The other PR has been merged, you can merge upstream. |
|
I think I created this PR just before @slim-bean's PR got merged. I will rebase this. |
adityacs
force-pushed
the
series_ingester_results
branch
from
005e3b7
to
e8021e8
Compare
adityacs
force-pushed
the
series_ingester_results
branch
2 times, most recently
from
b3936f4
to
d16b415
Compare
adityacs
force-pushed
the
series_ingester_results
branch
from
d16b415
to
2aca95d
Compare
|
This should not be merged. Looks like this change will induce one more data race. We have to fix this first #2265 |
|
This should be good to merge now. No change required on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While querying series API,
ingesterreturns the result even when the request time range is outside of chunk time range. This PR fixes this issue.