avoids further time splitting in querysharding mware #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @gouthamve should be happy about cortex/prom parity :) |
Codecov Report
@@ Coverage Diff @@
## master #2252 +/- ##
==========================================
- Coverage 62.34% 62.31% -0.04%
==========================================
Files 158 158
Lines 12760 12718 -42
==========================================
- Hits 7955 7925 -30
+ Misses 4193 4184 -9
+ Partials 612 609 -3
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Allow 1w in the period duration. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Add support for 1w, 1y to table manager retention Signed-off-by: Goutham Veeramachaneni <[email protected]> * Update docs and changelog Signed-off-by: Goutham Veeramachaneni <[email protected]> * Added model.Duration support to doc generator Signed-off-by: Marco Pracucci <[email protected]> * Fix infinite recursion in UnmarshalYAML. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Walk back integration config changes to support old versions Signed-off-by: Goutham Veeramachaneni <[email protected]> * Final nits Signed-off-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the cortexproject/cortex#2765 in loki