Docs: Local install edits #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 62.10% 62.10%
=======================================
Files 154 154
Lines 12457 12457
=======================================
Hits 7737 7737
Misses 4111 4111
Partials 609 609 |
cyriltovena
reviewed
Jun 16, 2020
cyriltovena
reviewed
Jun 16, 2020
Co-authored-by: Cyril Tovena <[email protected]>
owen-d
reviewed
Jun 19, 2020
owen-d
reviewed
Jun 19, 2020
owen-d
reviewed
Jun 19, 2020
owen-d
reviewed
Jun 19, 2020
owen-d
reviewed
Jun 19, 2020
owen-d
reviewed
Jun 19, 2020
Co-authored-by: Owen Diehl <[email protected]>
Co-authored-by: Owen Diehl <[email protected]>
…/loki into docs-local-install-edits
slim-bean
reviewed
Jun 22, 2020
slim-bean
reviewed
Jun 22, 2020
Co-authored-by: Ed Welch <[email protected]>
…/loki into docs-local-install-edits
oddlittlebird
commented
Jun 22, 2020
owen-d
approved these changes
Jun 22, 2020
slim-bean
reviewed
Jun 22, 2020
slim-bean
reviewed
Jun 22, 2020
Co-authored-by: Ed Welch <[email protected]>
Co-authored-by: Ed Welch <[email protected]>
Co-authored-by: Ed Welch <[email protected]>
|
Applied edits and renamed the file as requested. |
slim-bean
reviewed
Jun 22, 2020
docs/installation/local.md
Outdated
| ``` | ||
| wget https://raw.githubusercontent.com/grafana/loki/master/cmd/loki/loki-local-config.yaml | ||
| wget https://raw.githubusercontent.com/grafana/loki/master/cmd/promtail/promtail-local-config.yaml | ||
| wget NEED DOWNLOAD COMMAND |
There was a problem hiding this comment.
I think this third wget NEED DOWNLOAD COMMAND can be removed?
slim-bean
approved these changes
Jun 22, 2020
|
Fixed, @slim-bean |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* gRPC Storage Service This PR contains gRPC service client i.e 1. Index Client 2. Storage Client 3. Table Client Signed-off-by: vineeth <[email protected]> * Fixed the spaces in imports. Signed-off-by: Vineeth <[email protected]> * Made changes around review comments Signed-off-by: Vineeth Pothulapati <[email protected]> * Address the rpc message change from TableDesc to CreateTableRequest & added the logic to terminate connection on Stop() invocation. Signed-off-by: Vineeth Pothulapati <[email protected]> * Added the chnages in CHANGELOG.md & add information around rpc calls in grpc.proto Signed-off-by: Vineeth Pothulapati <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds information from the meeting where I interviewed Owen and Ed. Gives users information for installing, running, and getting logs into Loki.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: Please add information to download config files and run programs where indicated.
Checklist