BUG: add missing namespace in ingress object #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2205 +/- ##
=======================================
Coverage 62.14% 62.14%
=======================================
Files 154 154
Lines 12457 12457
=======================================
Hits 7741 7741
- Misses 4108 4109 +1
+ Partials 608 607 -1
|
cyriltovena
approved these changes
Jun 15, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Upgraded Prometheus client to 1.5.0 Signed-off-by: Marco Pracucci <[email protected]> * Fixed test-exporter compilation issue Signed-off-by: Marco Pracucci <[email protected]> * Fixed integration tests compilation Signed-off-by: Marco Pracucci <[email protected]> * Fixed tests Signed-off-by: Marco Pracucci <[email protected]>
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* add missing namespace in ingress object * update chart version * bump loki stack as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the Ingress object the namespace setting is missing.
I've added it and updated the version.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
none
Checklist
not needed