Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support querying labels on time range in logcli #2083

Merged
merged 1 commit into from
May 21, 2020

Conversation

adityacs
Copy link
Contributor

@adityacs adityacs commented May 16, 2020

What this PR does / why we need it:
logcli labels query was missing querying based on time range. This PR adds that support.

Checklist

  • Documentation added

@codecov-io
Copy link

Codecov Report

Merging #2083 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
- Coverage   61.31%   61.21%   -0.10%     
==========================================
  Files         146      146              
  Lines       11189    11195       +6     
==========================================
- Hits         6860     6853       -7     
- Misses       3784     3794      +10     
- Partials      545      548       +3     
Impacted Files Coverage Δ
pkg/logcli/client/client.go 5.98% <0.00%> (-0.33%) ⬇️
pkg/promtail/targets/tailer.go 73.86% <0.00%> (-4.55%) ⬇️
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@cyriltovena cyriltovena merged commit 360d9a7 into grafana:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants