-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update Loki Helm Chart document to support Helm 3 #2038
Conversation
Hello and thank you ! Does that still work with 2.0 helm ? I don't think it does so many we should add instruction for helm 3 instead or replacing with 2.0 what do you think ? |
The command that I updated does not work with Helm 2.
To install the chart in a specified namespace, the command is as below.
Given that Helm 3.0 was released about a half year ago, I think it'll be enough to support Helm 3.
|
Yes let’s do that ! |
updated! |
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
- Coverage 64.05% 63.88% -0.17%
==========================================
Files 133 133
Lines 10217 10217
==========================================
- Hits 6544 6527 -17
- Misses 3185 3203 +18
+ Partials 488 487 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for taking care of the feedback ! LGTM
* update Loki Helm Chart document to support Helm 3 * update Loki Helm Chart document to support Helm 2 & 3
What this PR does / why we need it:
This PR updates Loki Helm Chart document to support Helm 3.
-n
flag has been deprecated forhelm install
.Which issue(s) this PR fixes:
Fixes #1690
Special notes for your reviewer:
Checklist