Spelling #2014
Merged
Spelling #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cyriltovena
reviewed
Apr 30, 2020
| @@ -24,7 +24,7 @@ The current team members are: | |||
| - David Kaltschmidt [davkal](https://github.com/davkal) | |||
| - Edward Welch [slim-bean](https://github.com/slim-bean) | |||
| - Goutham Veeramachaneni [gouthamve](https://github.com/gouthamve) | |||
| - Joe Elliott [joe-elliot](https://github.com/joe-elliot) | |||
| - Joe Elliott [joe-elliott](https://github.com/joe-elliott) | |||
There was a problem hiding this comment.
Sorry @joe-elliott I did this.
slim-bean
reviewed
May 20, 2020
| @@ -739,7 +739,7 @@ A **huge** thanks to the **36 contributors** who submitted **148 PR's** since 0. | |||
| * **Build** [1121](https://github.com/grafana/loki/pull/1121) **pracucci**: Publish loki-canary binaries on release | |||
| * **Build** [1054](https://github.com/grafana/loki/pull/1054) **pstibrany**: Fix dep check warnings by running dep ensure | |||
| * **Build/release** [1018](https://github.com/grafana/loki/pull/1018) **slim-bean**: updating the image version for loki-canary and adding the version increment to the release_prepare script | |||
| * **Build/CI** [997](https://github.com/grafana/loki/pull/997) **slim-bean**: full cirlce | |||
| * **Build/CI** [997](https://github.com/grafana/loki/pull/997) **slim-bean**: full circle | |||
There was a problem hiding this comment.
lol this misspelling was intentional FWIW 😉
There was a problem hiding this comment.
I'm pretty sure I looked at the PR and decided it didn't need to be misspelled.
If something is very clearly intentionally misspelled and doesn't make sense otherwise, I do leave it alone, e.g. a changelog entry of spelling: cirlce -> circle.
My personal preference is to not include misspellings in changelogs, unless it's announcing an API change.
slim-bean
reviewed
May 20, 2020
| @@ -388,7 +388,7 @@ kvstore: | |||
| - <string> | |||
|
|
|||
| # The Dial timeout for the ETCD connection. | |||
| [dial_tmeout: <duration> | default = 10s] | |||
| [dial_timeout: <duration> | default = 10s] | |||
There was a problem hiding this comment.
are we 100% sure this is a typo in the docs and not a config actually spelled wrong?
There was a problem hiding this comment.
Afaict, the only instances of that are the document itself:
https://www.google.com/search?q=%22dial_tmeout%22
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* spelling: access * spelling: actual * spelling: asynchronously * spelling: circleci * spelling: circle * spelling: cognitive * spelling: comment * spelling: computation * spelling: correct * spelling: daemon * spelling: elliott * spelling: enabled * spelling: encbuf * spelling: extracted * spelling: explicitly * spelling: independent * spelling: languages * spelling: loose * spelling: message * spelling: metrics * spelling: mismatch * spelling: nonexistent * spelling: output * spelling: pipeline * spelling: pipe line * spelling: position * spelling: prepend * spelling: query * spelling: receive * spelling: received * spelling: reducible * spelling: registry * spelling: response * spelling: retryable * spelling: scanning * spelling: sourced * spelling: supported * spelling: template * spelling: timeout * spelling: unsupported * spelling: adapter * spelling: deferring * spelling: expirable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes misspellings across the project.
MIsspellings make it hard for people to understand code / search for code, etc.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Misspellings identified by the check-spelling action.
It reported: jsoref@1c3399c#commitcomment-38840752
And it validated that the changes in this PR made it happy: jsoref@ab2955b
Checklist