adds config validation, similar to cortex #1939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
After the 1.0 vendoring, we're exposed to some tricky configuration errors because we instantiate our configurations differently than cortex but use cortex's underlying configs. In this case, we loaded the schema's
PeriodConfig
blocks via yaml, causing subsequent calls toLoad
to no-op (this is intended to be an idempotent method).What
This PR introduces a
Config.Validate
function and calls it in the loki execution path - it mainly calls cortex validation code similar to cortex: https://github.com/cortexproject/cortex/blob/master/cmd/cortex/main.go#L83-L89Cortex
Load
: https://github.com/cortexproject/cortex/blob/master/pkg/chunk/schema_config.go#L228-L239I've tested this fix on one of our clusters and confirmed we're no longer seeing panics due to
0
(default go value) shard factors in our configs.