support match[] encoding
#1875
Merged
support match[] encoding
#1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @yeya24 @cyriltovena |
|
ugh, I didn't notice #1862 Sorry :( |
|
I think I can close mine. 😄 |
yeya24
reviewed
Mar 31, 2020
| ys := r.Form["match[]"] | ||
|
|
||
| deduped := union(xs, ys) | ||
| sort.Strings(deduped) |
There was a problem hiding this comment.
Can I ask why sorting is required?
There was a problem hiding this comment.
I did it for deterministic tests, but you're totally right - I could just sort it in the test. Good catch @yeya24
Edit: actually it looks a bit harder to sort it in tests and the runtime cost is minimal, so I'll leave it for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports a combination of
matchandmatch[]in encoding multiple match params (for Prometheus compatibility and because I usedmatchduring the initial implementation).Closes #1842