-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in labels debug message #1687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1687 +/- ##
==========================================
+ Coverage 63.27% 64.07% +0.79%
==========================================
Files 121 121
Lines 9027 9027
==========================================
+ Hits 5712 5784 +72
+ Misses 2897 2841 -56
+ Partials 418 402 -16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down! I agree with @cyriltovena, lets add a small test for this then LGTM.
@owen-d @cyriltovena need a small clarity. Just wanted to know what's the take here. Should we just remove |
I think removing the |
6c3aa95
to
c2abc7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a placeholder for now. Need to test more
What this PR does / why we need it:
Fix panic in labels debug message
Which issue(s) this PR fixes:
Fixes #1680