promtail: auto-prune stale metrics #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metrics pipeline stage after an idle period. Signed-off-by: Edward Welch <[email protected]>
slim-bean
force-pushed
the
auto-prune-promtail-metrics
branch
from
09bdacb
to
ebab59c
Compare
cyriltovena
reviewed
Feb 12, 2020
cyriltovena
reviewed
Feb 12, 2020
cyriltovena
reviewed
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1667
Given the dynamic nature of labels as outlined in that issue, it's possible to create metrics stage configuraitons which could create an unbounded growth of exported metrics.
This change should auto-prune metrics if they have not been used within a configurable time period.
The pruning takes place on the same thread and after Collect is called, this guarantees their last output is reported before pruning.
I debated if this should be done in a separate go routine but we would end up holding the same lock so it didn't seem like it would add much value doing it on a separate thread.
Signed-off-by: Edward Welch [email protected]