Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make manifest publishing run in serial #1633

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Feb 4, 2020

It looks like there's some issues with publishing the Docker manifest after a merge. This PR does two things:

  1. Make the CI fail if not all images in the manifest get published. This will be annoying but leads to less confusion.
  2. Runs the manifest steps serially. Running them in parallel might have been contributing to the manifest steps flaking before.

@rfratto rfratto force-pushed the fail-on-missing-image branch 2 times, most recently from 9a0305d to d6f057c Compare February 4, 2020 23:18
@codecov-io
Copy link

Codecov Report

Merging #1633 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
- Coverage   61.87%   61.84%   -0.03%     
==========================================
  Files         109      109              
  Lines        8304     8304              
==========================================
- Hits         5138     5136       -2     
- Misses       2773     2774       +1     
- Partials      393      394       +1
Impacted Files Coverage Δ
pkg/ingester/transfer.go 65% <0%> (-1.43%) ⬇️
pkg/logql/evaluator.go 91.75% <0%> (-1.04%) ⬇️
pkg/promtail/targets/tailer.go 78.16% <0%> (+2.29%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a try!

@slim-bean slim-bean merged commit f1dc58c into grafana:master Feb 5, 2020
@rfratto rfratto deleted the fail-on-missing-image branch September 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants