Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promtail helm chart] option to set fs.inotify.max_user_instances with init container #1620

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

rsteneteg
Copy link
Contributor

What this PR does / why we need it:
We ran into an issue on our Kubernetes environment where Promtail was using 113 inotify watchers, with some other watchers it it the 128 limit on watchers which resulted in "too many open files" error on the Kubernetes nodes.
Using an privileged init container to increase that limit fixed the issue for us, after the limit was raised the number of inotify watchers used by Promtail increased to about 175.

Which issue(s) this PR fixes:
Don't have a issue number for this.

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

…es through init container to resolve issue with too many open files

Signed-off-by: Roger Steneteg <[email protected]>
@rsteneteg rsteneteg changed the title [promtail helm chart] option to setfs.inotify.max_user_instances with init container [promtail helm chart] option to set fs.inotify.max_user_instances with init container Feb 3, 2020
@claassistantio
Copy link

claassistantio commented Feb 3, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@cyriltovena cyriltovena merged commit 87c2afc into grafana:master Feb 3, 2020
@stefanandres
Copy link

stefanandres commented Jun 16, 2021

Thanks! This saved me a lot of deployment work. Since this almost always needed when upgrading from Ubuntu 18.04 to Ubuntu 20.04 where they decreased the limit from 1024 to only 128 and promtail filling those quickly.

mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
…es through init container to resolve issue with too many open files (grafana#1620)

Signed-off-by: Roger Steneteg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants