Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov: Update config to add informational flag #1614

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

mattmendick
Copy link
Contributor

Setting the informational flag for the project so that we don't mark the checks as failed if the patch percentage is 0. See https://github.com/grafana/loki/pull/1612/commits for an example of a failure when it should really just tell us the information.

Setting the `informational` flag for the project so that we don't mark the checks as failed if the patch percentage is 0. See https://github.com/grafana/loki/pull/1612/commits for an example of a failure when it should really just tell us the information.
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattmendick mattmendick merged commit acb18b4 into master Jan 30, 2020
@mattmendick mattmendick deleted the codecov-make-informational branch January 30, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants