-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loki frontend docs additions #1611
Conversation
docs/configuration/query-frontend.md
Outdated
compress_responses: true | ||
|
||
frontend_worker: | ||
address: query-frontend.<namespace>.svc.cluster.local:9095 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think advertising http is better. so they don't have to change their querier setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the address for the queriers to connect to and they pull from the frontend over grpc. I don't think the queriers can pull over http.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear. I think we should remove this section. and use the downstream
property of the frontend config. The frontend will use http to request queriers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to use the frontend without changing anything else in your stack, just by adding a new service.
This is not the best way to use the frontend, I agree but this could be explained.
docs/configuration/query-frontend.md
Outdated
- name: query-frontend-http-metrics | ||
port: 80 | ||
protocol: TCP | ||
targetPort: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't target port be align with the frontend server config ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate? The frontend (in this example) listens on 80
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no the config file is set to 9090.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9091 ! hahaha
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
==========================================
+ Coverage 60.69% 60.75% +0.06%
==========================================
Files 107 107
Lines 8075 8075
==========================================
+ Hits 4901 4906 +5
+ Misses 2787 2784 -3
+ Partials 387 385 -2
|
Co-Authored-By: Cyril Tovena <[email protected]>
Co-Authored-By: Cyril Tovena <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSOTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1611 +/- ##
==========================================
+ Coverage 60.69% 60.75% +0.06%
==========================================
Files 107 107
Lines 8075 8075
==========================================
+ Hits 4901 4906 +5
+ Misses 2787 2784 -3
+ Partials 387 385 -2 |
What
Adds docs on the query frontend and some configuration examples in k8s.