Improve promtail configuration docs #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
requested changes
Jan 29, 2020
cyriltovena
reviewed
Jan 29, 2020
| ``` | ||
| ① This location needs to be writeable by promtail. | ||
| ② A `job` label is fairly standard in prometheus and useful for linking metrics and logs. |
There was a problem hiding this comment.
Should we say which label is mandatory and why or is it already somewhere?
There was a problem hiding this comment.
are any labels mandatory?
There was a problem hiding this comment.
well aside from __path__
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
=======================================
Coverage 60.63% 60.63%
=======================================
Files 106 106
Lines 8052 8052
=======================================
Hits 4882 4882
Misses 2784 2784
Partials 386 386 |
…, added the docker and cri stages, clarified and improved the examples a little. Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Co-Authored-By: Robert Fratto <[email protected]>
Co-Authored-By: Robert Fratto <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
slim-bean
force-pushed
the
improve-promtail-docs
branch
from
f39650c
to
77c32a9
Compare
rfratto
approved these changes
Feb 5, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* added interfaces for store spceific limits NewStore method in pkg/storage uses Overrides type defined in Cortex itself. Added an interface to let consumers of that method pass any type which implements required methods This is done as part of way to let projects using Cortex, define their own limits Signed-off-by: Sandeep Sukhani <[email protected]> * renamed interface CompositeStoreLimits to StoreLimits Signed-off-by: Sandeep Sukhani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1593 (or at least improves)
The promtail configs were missing the
dockerandcristages as well as had potentially confusing names in the docs vs the actual stage names.Also the docker example was difficult to follow because every OS logs docker logs to a different location.
Signed-off-by: Edward Welch [email protected]