fix(docs): tk init instructions #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Adds v11 schema to store label names within index. Stores only label names and not the entire metric. Storing entire metric will bloat the index by 30% and it doesn't really make sense to do it right now. Adding just label names adds a tolerable 7% to the index. Also, in Prometheus, we don't treat __name__ as a special label. We always return it when calling /labels API and we should do the same here. Signed-off-by: Cyril Tovena <[email protected]> Signed-off-by: Goutham Veeramachaneni <[email protected]> * Finishing touches fix lint issue Signed-off-by: Cyril Tovena <[email protected]> removes useless loop Signed-off-by: Cyril Tovena <[email protected]> This should be on v11 not v10. Signed-off-by: Cyril Tovena <[email protected]> s/metricConstRangeKeyV1/labelNamesRangeKeyV1/ The code was first written to store the entire series, but now changed to do just labelNames. Signed-off-by: Goutham Veeramachaneni <[email protected]> Add note about v11 being experimental. Signed-off-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: cyriltovena <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1301 (comment)
Fixes #1301