Promtail Helm Chart: Add support for passing environment variables #1529
Conversation
|
|
There was a problem hiding this comment.
Thanks for the PR! I see a problem in setting the env var, added a suggestion with a fix for it.
Some other suggestion regarding bumping up of version.
@cyriltovena I would appreciate your thoughts on this since I am fairly new to helm charts.
|
@cyriltovena please review |
|
You have conflicts, also why do you need env vars in promtails ? I don't think we support any env vars. |
Hi, @cyriltovena But I guess env vars support are really required feature |
* Make Promtail's Helm chart support passing extra env variables * bump charts versions
|
@cyriltovena We also had to pass environment variables to promtail to make it work in our environments. |
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
==========================================
- Coverage 61.84% 61.78% -0.07%
==========================================
Files 109 109
Lines 8304 8304
==========================================
- Hits 5136 5131 -5
- Misses 2774 2777 +3
- Partials 394 396 +2
|
…fana#1529) * Make Promtail's Helm chart support passing extra env variables * bump charts versions
What this PR does / why we need it:
This PR enables developers to pass environment variables to the
promtailcontainers via helm similarly to how it's done for lokiWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist