Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed typos/grammatical mistakes in metrics.md #15166

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ceosion
Copy link
Contributor

@ceosion ceosion commented Nov 27, 2024

What this PR does / why we need it:

Fixes a few typos & grammatical mistakes in metrics.md

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • [n/a] Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [n/a] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [n/a] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ceosion ceosion requested a review from a team as a code owner November 27, 2024 18:47
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 27, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM, thanks for taking the time to update the docs.

@JStickler JStickler changed the title fix(docs): fixed typos/grammatical mistakes in metrics.md docs: fixed typos/grammatical mistakes in metrics.md Dec 3, 2024
@JStickler JStickler merged commit 658fb24 into grafana:main Dec 3, 2024
59 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 658fb24)
loki-gh-app bot pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 658fb24)
loki-gh-app bot pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 658fb24)
loki-gh-app bot pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 658fb24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants