Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Rule Name and Type to Query Tags #15055

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bentonam
Copy link

What this PR does / why we need it:

When the ruler evaluation is remote, the only query tag set is source=ruler. When identifying problematic queries it would be more useful to have more than just the query and source=ruler. This adds support to also set the rule_name and rule_type.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Eventually, we may need to add namespace and group

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@bentonam bentonam requested a review from cstyan November 21, 2024 18:15
@bentonam bentonam requested a review from a team as a code owner November 21, 2024 18:15
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants