Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

positions.ignore-corruptions #1472

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jan 6, 2020

Adds a new config, positions.ignore-corruptions which allows ignoring corrupted yaml in the positions files. I believe this is already largely mitigated by the introduction of atomic file updates to the positions file.

This flag will not affect existing deployments, which error upon startup when finding malformed positions yaml.

closes #1460

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't know about referring to it as a "corrupted" file, since it would apply for any invalid YAML. WDYT about changing it to ignore_invalid_yaml?

@owen-d
Copy link
Member Author

owen-d commented Jan 6, 2020

I think you're right, @rfratto. I'll make the change

@rfratto rfratto merged commit 0b72ddb into grafana:master Jan 6, 2020
@pstibrany
Copy link
Member

I don't see much need for this. If one has corrupted positions file, and promtail doesn't start, then error message now says which file is the culprit, and admin can inspect / delete it. Alternatively admin can set this flag (as it defaults to false), but has to know about it first. As you point out, promtail should not generate corrupted position file anymore.

I would prefer if we reduced number of options rather than adding new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mangled positions results in promtail crash loop (k8s daemonset)
3 participants