Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement owned streams calculation using Partition Ring #14282

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:
Implements recalculateOwnedStreams logic using the partition ring.

  • The stream logic is unchanged but I isolated the ring-based logic into new components ("strategies") depending on the ring in use.
  • Also fixed a bug with the partition ring not initialising properly.

Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1117

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@benclive benclive requested a review from a team as a code owner September 26, 2024 10:41
Copy link
Contributor

@grobinson-grafana grobinson-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits!

pkg/ingester/ingester.go Outdated Show resolved Hide resolved
pkg/ingester/recalculate_owned_streams.go Outdated Show resolved Hide resolved
@benclive benclive merged commit 3c36ba9 into main Sep 26, 2024
62 checks passed
@benclive benclive deleted the benclive/implement-owned-streams-with-kafka branch September 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants