fluent-bit: tenant ID configuration #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This misses a line for dumping the configuration, will add this soon. |
JensErat
force-pushed
the
fluent-bit-tenant-id
branch
from
0de889f
to
c1a49cd
Compare
Both promtail and the fluentd plugin already have support for sending a tenant ID, and all necessary for doing so in fluent-bit is actually passing through the configuration item. Configuration is aligned with the fluentd plugin for consistency. We're lucky, since no configuration will result in an empty string that will be treated as no tenant ID by the Loki shipping client. Signed-off-by: Jens Erat <[email protected]>
Signed-off-by: Jens Erat <[email protected]>
JensErat
force-pushed
the
fluent-bit-tenant-id
branch
from
c1a49cd
to
e40a83d
Compare
|
This is ready to go from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Both promtail and the fluentd plugin already have support for sending a
tenant ID, and all necessary for doing so in fluent-bit is actually
passing through the configuration item. Configuration is aligned with
the fluentd plugin for consistency.
We're lucky, since no configuration will result in an empty string that
will be treated as no tenant ID by the Loki shipping client.
This has also been tested against the most current Loki server release.
I also sneaked in a minor documentation spelling fix on the go.
Which issue(s) this PR fixes:
Not being able to send tenant ID without reverse proxy.
Special notes for your reviewer:
Checklist