fix: fix setting of info log level when trying to detect level from log lines #12635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
approved these changes
Apr 16, 2024
|
Please rollout this version soon, this bug affecting our production logs |
This was referenced Apr 18, 2024
Closed
This was referenced Apr 22, 2024
|
Could we get a 3.x release with this fix soon? |
|
When will the Loki Helm charts be updated? We just updated with Helm v6.5.1 (v3.0.0) and it still shows the wrong log-level (i see it is tagged for a 3.1.x release) |
This was referenced May 13, 2024
This was referenced May 27, 2024
|
Is there an ETA on when this will be merged in? It was fixed 3 weeks ago and the latest Loki does not reflect the changes so the image tag version in the Helm charts cannot even be updated. |
This was referenced Jun 10, 2024
|
Still hasn't been released? |
This was referenced Jul 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I made a mistake while setting log level for info logs with logfmt/json format. This PR fixes it.