Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback google.golang.org/api to 0.8.0 #1237

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Nov 6, 2019

What this PR does / why we need it:
Loki ingesters are suffering from a slow goroutine leak most likely due to:

googleapis/google-cloud-go#1380

This issue is not seen in other applications using 0.8.0. Hail marying a rollback to see if it fixes the issue.

Signed-off-by: Joe Elliott <[email protected]>
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@rfratto rfratto merged commit 3d2c643 into grafana:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants