Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-driver Dockerfile: add tzdb #1233

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Update docker-driver Dockerfile: add tzdb #1233

merged 1 commit into from
Nov 13, 2019

Conversation

wapmorgan
Copy link
Contributor

@wapmorgan wapmorgan commented Nov 5, 2019 •
edited
Loading

Fix error "invalid timestamp stage config: invalid location specified: unknown time zone Europe/Moscow" when specifying location in timestamp stage

What this PR does / why we need it: tzdata is required for time.LoadLocation() function.

@wapmorgan
Update docker-driver Dockerfile: add tzdb
2c181cb 
Fix error "invalid timestamp stage config: invalid location specified: unknown time zone Europe/Moscow" when specifying `location` in [timestamp stage](https://github.com/grafana/loki/blob/master/docs/clients/promtail/stages/timestamp.md)
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wapmorgan
Copy link
Contributor Author

So, what loki maintainers think about it?

@cyriltovena
Copy link
Contributor

Looks great, I just need time to test this locally, have you tried it on your side, what is the timestamp stage your are using for reference please ? I want to reproduce.

@cyriltovena cyriltovena self-requested a review November 13, 2019 01:11
@wapmorgan
Copy link
Contributor Author

wapmorgan commented Nov 13, 2019 •
edited
Loading

@cyriltovena any timestamp stage with iana timezone identifier in location:

pipeline_stages:
- json:
    expressions:
...
- timestamp:
    source: timestamp
    format: 2006-01-02 15:04:05.999999
    location: 'Europe/Moscow'

If tzdata is not installed, any location can not be found: invalid timestamp stage config: invalid location specified: unknown time zone Europe/Moscow

cyriltovena
cyriltovena approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit c1e84b5 into grafana:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wapmorgan @CLAassistant @cyriltovena