Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): add protocol and port for default compactorAddress #12191

Merged
merged 4 commits into from
Mar 15, 2024
Merged

fix(helm): add protocol and port for default compactorAddress #12191

merged 4 commits into from
Mar 15, 2024

Conversation

taind772
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #12179

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@taind772 taind772 requested a review from a team as a code owner March 13, 2024 06:32
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MichelHollands MichelHollands merged commit 0a90f05 into grafana:main Mar 15, 2024
13 checks passed
@taind772 taind772 mentioned this pull request Mar 15, 2024
Merged
8 tasks
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@taind772 @MichelHollands @rhnasc
fix(helm): add protocol and port for default compactorAddress (grafan…
7d4a0ff 
…a#12191)

Co-authored-by: Michel Hollands <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@taind772 @MichelHollands
fix(helm): add protocol and port for default compactorAddress (grafan…
500bbc4 
…a#12191)

Co-authored-by: Michel Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loki read: unsupported protocol scheme
3 participants
@taind772 @CLAassistant @MichelHollands