Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): Change attribute value used for CCO-based credential mode #12165

Merged
merged 6 commits into from
Mar 12, 2024
Merged

feat(operator): Change attribute value used for CCO-based credential mode #12165

merged 6 commits into from
Mar 12, 2024

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Mar 8, 2024 •
edited by xperimental
Loading

What this PR does / why we need it:

Updates mention of managed auth to token cco auth as discussed

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • CHANGELOG.md updated

@JoaoBraveCoding JoaoBraveCoding force-pushed the managed-to-token-cco branch 2 times, most recently from 8cdcf6f to 5f9acab Compare March 8, 2024 11:16
@xperimental xperimental changed the title chore(operator): updates credential mode managed to token cco feat(operator): Change API value used for CCO-based credential mode Mar 8, 2024
@xperimental xperimental changed the title feat(operator): Change API value used for CCO-based credential mode feat(operator): Change attribute value used for CCO-based credential mode Mar 8, 2024
xperimental
xperimental reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I realized too late, that I needed a different test cluster to properly test this. Will do that on Monday. Some small comments, mostly regarding documentation comments.

operator/apis/loki/v1/lokistack_types.go Outdated Show resolved Hide resolved
operator/apis/loki/v1/lokistack_types.go Outdated Show resolved Hide resolved
operator/apis/loki/v1/lokistack_types.go Outdated Show resolved Hide resolved
operator/internal/manifests/var.go Outdated Show resolved Hide resolved
xperimental
xperimental reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another test, works fine.

Only one thing missing: The api.md file needs to be regenerated.

@xperimental xperimental merged commit 3eee541 into grafana:main Mar 12, 2024
17 of 18 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@JoaoBraveCoding @rhnasc
feat(operator): Change attribute value used for CCO-based credential …
16f678d 
…mode (grafana#12165)
@JoaoBraveCoding JoaoBraveCoding deleted the managed-to-token-cco branch July 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental xperimental approved these changes

@periklis periklis Awaiting requested review from periklis periklis is a code owner

Assignees
No one assigned
Labels
sig/operator size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoaoBraveCoding @xperimental