-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace zip with gzip #1160
Merged
Merged
replace zip with gzip #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
pstibrany
reviewed
Oct 17, 2019
Signed-off-by: Xiang Dai <[email protected]>
@sh0rez any update? |
cyriltovena
requested review from
slim-bean
and removed request for
pstibrany
November 24, 2019 23:29
@slim-bean @cyriltovena any update? |
pstibrany
reviewed
Nov 29, 2019
sh0rez
requested changes
Nov 30, 2019
Rebase your branch please, CI is failing |
sh0rez
added
component/packaging
type/enhancement
Something existing could be improved
labels
Nov 30, 2019
Signed-off-by: Xiang Dai <[email protected]>
@sh0rez mind have a look? |
pstibrany
reviewed
Dec 2, 2019
Signed-off-by: Xiang Dai <[email protected]>
pstibrany
approved these changes
Dec 2, 2019
sh0rez
requested changes
Dec 2, 2019
Signed-off-by: Xiang Dai <[email protected]>
sh0rez
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1113
Signed-off-by: Xiang Dai [email protected]