Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace zip with gzip #1160

Merged
merged 7 commits into from
Dec 3, 2019
Merged

replace zip with gzip #1160

merged 7 commits into from
Dec 3, 2019

Conversation

daixiang0
Copy link
Contributor

Fix #1113

Signed-off-by: Xiang Dai [email protected]

tools/release-note.md Outdated Show resolved Hide resolved
Signed-off-by: Xiang Dai <[email protected]>
@daixiang0
Copy link
Contributor Author

@sh0rez any update?

@daixiang0
Copy link
Contributor Author

@sh0rez @rfratto any update?

@cyriltovena cyriltovena requested review from slim-bean and removed request for pstibrany November 24, 2019 23:29
@daixiang0
Copy link
Contributor Author

@slim-bean @cyriltovena any update?

Makefile Outdated Show resolved Hide resolved
tools/release-note.md Outdated Show resolved Hide resolved
tools/release-note.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sh0rez
Copy link
Member

sh0rez commented Nov 30, 2019

Rebase your branch please, CI is failing

@sh0rez sh0rez added component/packaging type/enhancement Something existing could be improved labels Nov 30, 2019
@sh0rez sh0rez self-assigned this Nov 30, 2019
Signed-off-by: Xiang Dai <[email protected]>
@daixiang0
Copy link
Contributor Author

@sh0rez mind have a look?

tools/release-note.md Outdated Show resolved Hide resolved
Signed-off-by: Xiang Dai <[email protected]>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Xiang Dai <[email protected]>
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sh0rez sh0rez merged commit 1dcf3d3 into grafana:master Dec 3, 2019
@daixiang0 daixiang0 deleted the zip branch December 3, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different packaging for release binaries
3 participants