Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep => go mod #1062

Merged
merged 47 commits into from
Sep 30, 2019
Merged

dep => go mod #1062

merged 47 commits into from
Sep 30, 2019

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Sep 25, 2019

What this PR does / why we need it:
Changes Loki package management from dep to go modules.

Special notes for your reviewer:
This is a parallel effort to #571.

  • Removed dep files and added go module files dependency files
  • Built loki-build-image 0.6.0 to migrate to 1.12
  • Updated all build images to use /src/loki to force usage of go modules
  • Added details to contributing.md
  • Minor codebase changes to handle dependency changes
  • Makefile has been updated to force using vendored dependencies

@daixiang0
Copy link
Contributor

cool

Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
…ndencies"

This reverts commit 65865a24c9a23133e0fa52942f2828ead7c22147.
@joe-elliott joe-elliott marked this pull request as ready for review September 27, 2019 18:50
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit fc6c5c0 into grafana:master Sep 30, 2019
@sh0rez
Copy link
Member

sh0rez commented Sep 30, 2019

Wow! This is super awesome! Thanks y‘all! 🎉 🍿

cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
This was added in July 2017 as a backwards-compatibility measure;
removing now nobody uses it.

Signed-off-by: Bryan Boreham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants