Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loki push path #1049

Merged
merged 13 commits into from
Sep 25, 2019
Merged

Update loki push path #1049

merged 13 commits into from
Sep 25, 2019

Conversation

joe-elliott
Copy link
Member

What this PR does / why we need it:
All of the other Loki paths were updated to be versioned and contain a /loki prefix. This finishes the job by also updating the push path.

Special notes for your reviewer:

  • Anything under /docs was ignored due to @rfratto 's pending documentation PR. I double checked he covered the path change.
  • This makes several changes to production configs and should be checked carefully
    • promtail helm chart and version were updated
    • fluentd plugin was updated. does the gem version need to be incremented?
    • loki gateway was updated to support both old and new paths
  • Should some of these updates wait for when we have these new paths active in the prod environments?

Checklist

  • Documentation added
  • Tests updated

@cyriltovena
Copy link
Contributor

fluentd plugin was updated. does the gem version need to be incremented?

Yes let's create an issue, is it the case for the docker driver too ? I think so.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this LGTM but I'd like a second person to approve it.
@cyriltovena I think the docker driver gets published by CI every time we do a tag.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-elliott
Copy link
Member Author

  • Updated gem version due to path change
  • Reverted helm chart changes and helm chart version
  • Docker driver does not need a version update. It builds directly off of the tip of master and is probably verisoned when we do a loki release along with promtail and loki.

Signed-off-by: Joe Elliott <[email protected]>
@rfratto rfratto merged commit 778c0b6 into grafana:master Sep 25, 2019
@rfratto rfratto mentioned this pull request Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants