doc(ksonnet): include ksonnet-lib #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiang Dai <[email protected]>
|
@sh0rez please review it. |
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
sh0rez
requested changes
Sep 23, 2019
There was a problem hiding this comment.
Not sure about this, we really don't need to repeat all the info for Loki as well, we might rather want to restructure this doc to make sure people are aware of the fact that Tanka basically takes jsonnet libraries and composes them to application stacks.
There is also no need for using the default environment, when deploying loki it should be in a loki env
Signed-off-by: Xiang Dai <[email protected]>
sh0rez
requested changes
Sep 24, 2019
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
daixiang0
force-pushed
the
fix-ksonnect
branch
from
57fa2b3
to
6212147
Compare
sh0rez
requested changes
Sep 24, 2019
sh0rez
added
component/docs
component/packaging
type/enhancement
Signed-off-by: Xiang Dai <[email protected]>
sh0rez
reviewed
Sep 24, 2019
Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
sh0rez
changed the title
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
Now that QueryPages() runs across multiple goroutines, the callback can be running in parallel so we need to lock round the single data structure it is accessing. Signed-off-by: Bryan Boreham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since replace ksonnet with Tanka, doc need to update to latest.
Signed-off-by: Xiang Dai [email protected]