Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-driver: do not truncate the container id in loki-external-labels #3795

Closed
rgl opened this issue Jun 3, 2021 · 1 comment
Closed

Comments

@rgl
Copy link
Contributor

rgl commented Jun 3, 2021

Describe the solution you'd like

Some way to have the full container id logged in loki.

When using this in docker, we can use --no-trunc (as in docker ps --no-trunc) to show the full id. But in the context of loki, I think, it should never truncate anything.

cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
Signed-off-by: Benjamin Charron <[email protected]>

Co-authored-by: Benjamin Charron <[email protected]>
@rgl
Copy link
Contributor Author

rgl commented Jun 13, 2021

Oh, sorry, this is actually already supported by the docker log tags by using {{.FullID}}.

@rgl rgl closed this as completed Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant