Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memberlist TLS #3750

Closed
c0ffeec0der opened this issue May 20, 2021 · 2 comments
Closed

memberlist TLS #3750

c0ffeec0der opened this issue May 20, 2021 · 2 comments
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@c0ffeec0der
Copy link
Contributor

Is your feature request related to a problem? Please describe.
securing memberlist tcp traffic

Describe the solution you'd like
expose the same member_config parameter as cortex (https://cortexmetrics.io/docs/configuration/configuration-file/#memberlist_config)

i.e
tls_enabled
tls_insecure_skip_verify
tls_ca_path
tls_cert_path
tls_key_path

Describe alternatives you've considered
None, we have to use unencrypted traffic
@c0ffeec0der
Copy link
Contributor Author

The cortex TLS config was commited on Apr 10. Latest loki release was on Apr 6. Will wait for next release and retest

cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@pstibrany
Tenant deletion: ruler support. (grafana#3750)
038c5af 
* Tenant deletion: ruler support.

Ruler now deletes local files for users that it no longer should process rules for.

Tenant deletion API now works with rule groups directly (deletes, lists).

Signed-off-by: Peter Štibraný <[email protected]>

* Make support for rule deletion optional.

Signed-off-by: Peter Štibraný <[email protected]>

* Review feedback.

Signed-off-by: Peter Štibraný <[email protected]>

* Auto-detect if rule store supports modifications, and only clean rules if it does.

Signed-off-by: Peter Štibraný <[email protected]>

* Add test for read-only rule store.

Signed-off-by: Peter Štibraný <[email protected]>

* Fix docs.

Signed-off-by: Peter Štibraný <[email protected]>

* Fix tests.

Signed-off-by: Peter Štibraný <[email protected]>

* Fix changelog.

Signed-off-by: Peter Štibraný <[email protected]>

* Fix comment.

Signed-off-by: Peter Štibraný <[email protected]>

* Disable rule groups deletion in purger, if storage is not configured.

Signed-off-by: Peter Štibraný <[email protected]>
@stale
Copy link

stale bot commented Jun 20, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jun 20, 2021
@stale stale bot closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c0ffeec0der